Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support url-encoded OTEL_EXPORTER_OTLP_HEADERS values #1242

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Feb 28, 2024

Per a recent spec clarification in open-telemetry/opentelemetry-specification#3832 OTLP headers should support url-encoded header values.

Fixes: #1239

Per a recent spec clarification in open-telemetry/opentelemetry-specification#3832 OTLP
headers should support url-encoded header values.
@brettmc brettmc requested a review from a team February 28, 2024 10:06
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (b20c45d) to head (b592c58).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1242      +/-   ##
============================================
- Coverage     83.09%   83.08%   -0.02%     
+ Complexity     2275     2273       -2     
============================================
  Files           285      285              
  Lines          6460     6455       -5     
============================================
- Hits           5368     5363       -5     
  Misses         1092     1092              
Flag Coverage Δ
7.4 81.72% <100.00%> (-0.02%) ⬇️
8.0 82.98% <100.00%> (-0.02%) ⬇️
8.1 83.14% <100.00%> (-0.02%) ⬇️
8.2 83.14% <100.00%> (-0.02%) ⬇️
8.3 83.14% <100.00%> (-0.02%) ⬇️
8.4 83.14% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Contrib/Otlp/LogsExporterFactory.php 100.00% <100.00%> (ø)
src/Contrib/Otlp/MetricExporterFactory.php 97.61% <100.00%> (-0.16%) ⬇️
src/Contrib/Otlp/OtlpUtil.php 73.68% <100.00%> (+12.14%) ⬆️
src/Contrib/Otlp/SpanExporterFactory.php 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20c45d...b592c58. Read the comment docs.

Co-authored-by: Tobias Bachert <[email protected]>
@brettmc brettmc merged commit 258e586 into open-telemetry:main Feb 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL encoded values for OTEL_EXPORTER_OTLP_HEADERS are not supported
3 participants