Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrument advisory parameter #1186

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Dec 9, 2023

See spec, adds an optional $advisory parameter to all Meter::createXXX() methods.

Use case http.server.request.duration:

This metric SHOULD be specified with ExplicitBucketBoundaries of [ 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10 ].

Nevay added 2 commits December 9, 2023 11:45
"SDKs SHOULD use the default value when boundaries are not explicitly provided, unless they have good reasons to use something different (e.g. for backward compatibility reasons in a stable SDK release)."
@Nevay Nevay requested a review from a team December 9, 2023 11:38
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #1186 (c9d2bb6) into main (a6d15cf) will decrease coverage by 0.06%.
The diff coverage is 68.88%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1186      +/-   ##
============================================
- Coverage     84.35%   84.29%   -0.06%     
- Complexity     2193     2196       +3     
============================================
  Files           282      282              
  Lines          6224     6245      +21     
============================================
+ Hits           5250     5264      +14     
- Misses          974      981       +7     
Flag Coverage Δ
7.4 82.93% <68.88%> (-0.06%) ⬇️
8.0 84.22% <68.88%> (-0.06%) ⬇️
8.1 84.35% <68.88%> (-0.06%) ⬇️
8.2 84.35% <68.88%> (-0.06%) ⬇️
8.3 84.35% <68.88%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/SDK/Metrics/DefaultAggregationProviderTrait.php 100.00% <100.00%> (ø)
src/SDK/Metrics/MetricReader/ExportingReader.php 73.84% <100.00%> (ø)
src/SDK/Metrics/Instrument.php 0.00% <0.00%> (ø)
src/API/Metrics/Noop/NoopMeter.php 0.00% <0.00%> (ø)
src/SDK/Metrics/Meter.php 92.00% <81.25%> (-2.84%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d15cf...c9d2bb6. Read the comment docs.

@brettmc brettmc merged commit d376566 into open-telemetry:main Dec 13, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants