Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sdk console metrics exporter #1055

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jun 26, 2023

to make getting started easier (in opentelemetry.io docs), create an sdk-based metrics exporter. this means we can export all signals without needing a protobuf implementation. since console export is only useful for playing around, the change in format to a simpler human-readable output seems reasonable.

to make getting started easier (in opentelemetry.io docs), create an sdk-based metrics
exporter. this means we can export all signals without needing a protobuf implementation.
since console export is only useful for playing around, the change in format to a
simpler human-readable output seems reasonable.
@brettmc brettmc requested a review from a team June 26, 2023 06:27
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1055 (b6d91d9) into main (49638ea) will decrease coverage by 0.38%.
The diff coverage is 2.22%.

❗ Current head b6d91d9 differs from pull request most recent head 7f9f8f8. Consider uploading reports for the commit 7f9f8f8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1055      +/-   ##
============================================
- Coverage     82.03%   81.66%   -0.38%     
- Complexity     2175     2186      +11     
============================================
  Files           277      278       +1     
  Lines          6185     6228      +43     
============================================
+ Hits           5074     5086      +12     
- Misses         1111     1142      +31     
Flag Coverage Δ
7.4 80.31% <2.22%> (-0.37%) ⬇️
8.0 81.60% <2.22%> (-0.38%) ⬇️
8.1 81.73% <2.22%> (-0.45%) ⬇️
8.2 81.73% <2.22%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Logs/Exporter/ConsoleExporter.php 100.00% <ø> (ø)
.../Metrics/MetricExporter/ConsoleMetricsExporter.php 0.00% <0.00%> (ø)
...cs/MetricExporter/ConsoleMetricExporterFactory.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49638ea...7f9f8f8. Read the comment docs.

@pdelewski
Copy link
Member

LGTM

@brettmc brettmc merged commit a0601c4 into open-telemetry:main Jun 26, 2023
@brettmc brettmc deleted the metrics-console-exporter branch July 17, 2023 01:00
sahya added a commit to sahya/opentelemetry.io that referenced this pull request Jan 4, 2024
Because the path was changed in opentelemetry-php PR
open-telemetry/opentelemetry-php#1055
sahya pushed a commit to sahya/opentelemetry.io that referenced this pull request Jan 4, 2024
Because the path was changed in opentelemetry-php PR
open-telemetry/opentelemetry-php#1055
sahya added a commit to sahya/opentelemetry.io that referenced this pull request Jan 4, 2024
sahya added a commit to sahya/opentelemetry.io that referenced this pull request Jan 4, 2024
Because the path was changed in opentelemetry-php PR
open-telemetry/opentelemetry-php#1055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants