-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding sdk console metrics exporter #1055
Conversation
to make getting started easier (in opentelemetry.io docs), create an sdk-based metrics exporter. this means we can export all signals without needing a protobuf implementation. since console export is only useful for playing around, the change in format to a simpler human-readable output seems reasonable.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
============================================
- Coverage 82.03% 81.66% -0.38%
- Complexity 2175 2186 +11
============================================
Files 277 278 +1
Lines 6185 6228 +43
============================================
+ Hits 5074 5086 +12
- Misses 1111 1142 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LGTM |
Because the path was changed in opentelemetry-php PR open-telemetry/opentelemetry-php#1055
Because the path was changed in opentelemetry-php PR open-telemetry/opentelemetry-php#1055
Because the path was changed in opentelemetry-php PR open-telemetry/opentelemetry-php#1055
Because the path was changed in opentelemetry-php PR open-telemetry/opentelemetry-php#1055
to make getting started easier (in opentelemetry.io docs), create an sdk-based metrics exporter. this means we can export all signals without needing a protobuf implementation. since console export is only useful for playing around, the change in format to a simpler human-readable output seems reasonable.