guard against possible false value from file_get_contents in Host.php

open-telemetry · Nov 7, 2024 · fa79d54 · fa79d54
1 parent 38633fb
commit fa79d54
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/SDK/Resource/Detectors/Host.php b/src/SDK/Resource/Detectors/Host.php
@@ -54,7 +54,8 @@ private function getLinuxId(): ?string
         foreach ($paths as $path) {
             $file = $this->dir . $path;
             if (is_file($file) && is_readable($file)) {
-                return trim(file_get_contents($file));
+                $contents = file_get_contents($file);
+                return $contents !== false ? trim($contents) : null;
             }
         }
 
@@ -65,7 +66,8 @@ private function getBsdId(): ?string
     {
         $file = $this->dir . self::PATH_ETC_HOSTID;
         if (is_file($file) && is_readable($file)) {
-            return trim(file_get_contents($file));
+            $contents = file_get_contents($file);
+            return $contents !== false ? trim($contents) : null;
         }
 
         $out = exec('which kenv && kenv -q smbios.system.uuid');