-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 8.4 segfaults, test against PHP nightly #153
Conversation
- build against PHP nightly on PR and daily schedule - use setup-php for linux builds (which drops Alpine builds)
FYI using this patch it shows failure on 32-bits like this
|
Was able to replicate this using i386/alpine docker image... |
- remove the ability to pass complex items as attributes (since the spec already disallows them, they'd get dropped later anyway) - update alpine dockerfile to also support 32bit builds, which enables local testing against a 32bit platform
It should be green now against 32bit builds, @andypost |
Thank you! It passed on all arches! btw I noticed that CI here is not using latest stable Alpine version (3.20) |
Fixes: open-telemetry/opentelemetry-php#1376