Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create draft release on tag, publish windows and pecl builds #109

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Nov 10, 2023

This automates the publishing of some artifacts:

  • windows binaries
  • PECL package
    Those artifacts are generated on each action run, uploaded and available from the relevant github action.

When a tag is pushed, it will also create a release for that tag, uploading the artifacts to the release page. For this to work, you need to create a tag without a release (which you can't do from github UI, so I've got a separate PR coming for dev-tools which creates a tag).

Closes: open-telemetry/opentelemetry-php#1160

brettmc and others added 2 commits November 10, 2023 13:01
dont clobber the dockerfile arg for PHP_CONFIG_OPTS, which includes --with-pear. this will allow us to pear package within the build
@brettmc
Copy link
Collaborator Author

brettmc commented Nov 15, 2023

Feedback from some participants at today's SIG was that the windows binaries could be installed and pass some basic testing. That's good enough for me to start publishing them.

@brettmc brettmc merged commit 12be89e into open-telemetry:main Nov 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry-php-instrumentation] - store windows builds as artifacts
2 participants