Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure correct version of operator-sdk is always used #728

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

pavolloffay
Copy link
Member

This PR installs operator-sdk to ./bin which makes sure
that always correct version of operator-sdk is used.

This should solve issues like #719 (comment)

Signed-off-by: Pavol Loffay [email protected]

This PR installs operator-sdk to ./bin which makes sure
that always correct version of operator-sdk is used.

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay requested review from a team and bogdandrutu February 21, 2022 09:42
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay changed the title Make sure the correct version of operator-sdk is always used Make sure correct version of operator-sdk is always used Feb 21, 2022
@pavolloffay
Copy link
Member Author

@VineethReddy02 / @jpkrohling could you please review?

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavolloffay pavolloffay merged commit 462c4a5 into open-telemetry:main Feb 22, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…try#728)

* Make sure the correct version of operator-sdk is always used

This PR installs operator-sdk to ./bin which makes sure
that always correct version of operator-sdk is used.

Signed-off-by: Pavol Loffay <[email protected]>

* Create dir

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants