Add appProtocol for otlp and jaeger receiver parsers

[binjip978]

Signed-off-by: Sergei Semenchuk [email protected]

[pavolloffay]

LGTM,

if you could fix as well Zipkin that would be great, it's often times used in service mesh.

It would be great as well improve e2e test and assert the service e.g. https://github.com/open-telemetry/opentelemetry-operator/blob/main/tests/e2e/smoke-simplest/00-assert.yaml

[VineethReddy02]

Few tests are failing in the CI more details: https://github.com/open-telemetry/opentelemetry-operator/runs/5137930906?check_suite_focus=true#step:7:776

[binjip978]

Few tests are failing in the CI more details: https://github.com/open-telemetry/opentelemetry-operator/runs/5137930906?check_suite_focus=true#step:7:776

yeah, it's quite tricky to run the full suite on mac, but it should be fine now.

[binjip978]

LGTM,

if you could fix as well Zipkin that would be great, it's often times used in service mesh.

It would be great as well improve e2e test and assert the service e.g. https://github.com/open-telemetry/opentelemetry-operator/blob/main/tests/e2e/smoke-simplest/00-assert.yaml

for the zipkin part, I'm not really familiar with it and looks like it use GenericReceiver, so it's possible to setup TCP if the name is zipkin, but I'm not sure about appProtocol, it should be http, http2 or grcp? Looks like it depends https://zipkin.io/pages/tracers_instrumentation

[pavolloffay]

Zipkin uses http

[pavolloffay]

Please add the e2e test- verify the service has the protocol set.

[pavolloffay]

I am not sure about this approach. The protocol type should be rather set in

opentelemetry-operator/pkg/collector/parser/receiver_zipkin.go

Line 23 in eb549ce

return &GenericReceiver{

and then just used to configure the service

[binjip978]

@pavolloffay just to be clear for zipkin config we can expect something like this:

zipkin:
---
zipkin:
  protocols:
    http:
      endpoint: "0.0.0.0:9999"

And in case of default config "zipkin:" is this ok to add to GenericReceiver fields like defaultProtocol and defaultAppProtocol?

[pavolloffay]

I think we will have to add a field there