Update nodejs instrumentation to 0.27.0 #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Feb 2, 2022
| @@ -19,6 +19,7 @@ | |||
| "noImplicitReturns": true, | |||
| "noUnusedLocals": true, | |||
| "pretty": true, | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
By default, TS does a deep typecheck through transitive dependencies. I don't know if it's a but in opentelemetry-js (/cc @dyladan) but after updating I got a transitive type failure on graphql library.
For our meager code, the transitive type check is definitely not needed.
pavolloffay
approved these changes
Feb 2, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And runs build on PR