Fix collector config update #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mcariapas
force-pushed
the
pod_sum_annotation
branch
from
ed44dcb to
2b4da33
Compare
|
|
|
@pavolloffay Can you review it? |
pavolloffay
reviewed
Jan 24, 2022
There was a problem hiding this comment.
Thanks for looking into this and it looks good to me ❤️
I would love to see e2e test for this change (something like this)
- deploy collector as deployment
- assert it is deployed
- change config in CR - e.g. add new receiver
- assert the collector pod restarted with the new changes - check if the new receiver port is exposed.
|
Done, please review it. |
mcariapas
force-pushed
the
pod_sum_annotation
branch
from
8a1bb8b to
68e98df
Compare
|
mcariapas
force-pushed
the
pod_sum_annotation
branch
2 times, most recently
from
557ed9d to
f216c31
Compare
|
mcariapas
force-pushed
the
pod_sum_annotation
branch
2 times, most recently
from
1b175bd to
f216c31
Compare
pavolloffay
approved these changes
Jan 26, 2022
pavolloffay
changed the title
|
@pavolloffay @Aneurysm9 Can we merge it before the next release? |
|
yes, thanks for the PR :) cc) @jpkrohling @VineethReddy02 could you please merge? |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* fix/460 : Added opentelemetry-operator-config/sha256 annotaton to pod annotations * PR comments fixes * Created e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added check sum to pod annotations. This will fix rollout when the collector config changes.
Yes, I know this is duplicated pull request with #506
but the other one has been forgotten for some time.
Fixes #460