Add support for nodejs and python image defaulting and upgrade #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
@VineethReddy02 would you like to review? |
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
changed the title
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
@VineethReddy02 friendly ping. Please review this one, it finishes the feature parity for all auto-instrumentations. |
VineethReddy02
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Thanks for this PR @pavolloffay
LGTM!
cc @jpkrohling for the final review (totally optional Juraci, if you are occupied)!
| inst.Annotations[v1alpha1.AnnotationDefaultAutoInstrumentationNodeJS] = u.DefaultAutoInstrNodeJS | ||
| } | ||
| } | ||
| autoInstNodePython := inst.Annotations[v1alpha1.AnnotationDefaultAutoInstrumentationPython] |
There was a problem hiding this comment.
autoInstNodePython -> autoInstPython node as python suffix is bit confusing.
There was a problem hiding this comment.
good catch this is a typo. fixed
Signed-off-by: Pavol Loffay <[email protected]>
Your approval is enough. Merging. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…telemetry#607) * Add support nodejs and python image defaulting and upgrade Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> * Fix typo Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Defaulting and upgrading for Java auto-instrumentation already exists.