Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoinstrumentation/nodejs] update node dependencies #3475

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

msvechla
Copy link
Contributor

This updates the dependencies of the autoinstrumentation for nodejs to the latest available versions.

There have been some important bugfixes for us recently.

@msvechla msvechla requested a review from a team as a code owner November 20, 2024 10:18
Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog?

@msvechla
Copy link
Contributor Author

Could you add a changelog?

Done, let me know if the changelog entry looks good!

@swiatekm
Copy link
Contributor

Can we wait until #3466 is merged and rebase on that? CC @pavolloffay

@pavolloffay
Copy link
Member

The PR needs to be rebased

This updates the dependencies of the autoinstrumentation for nodejs to
the latest available versions.

There have been some important bugfixes for us recently.

Signed-off-by: Marius Svechla <[email protected]>
@msvechla
Copy link
Contributor Author

I rebased and adjusted the package.json and changelog accordingly

@pavolloffay pavolloffay merged commit cdff25a into open-telemetry:main Nov 25, 2024
39 checks passed
@msvechla
Copy link
Contributor Author

msvechla commented Nov 28, 2024

@pavolloffay @swiatekm does any of you have an idea why no new autoinstrumentation-nodejs was published, even though a new version has been released?

Did I miss to update something? Thanks for your help!

Ahh never mind, I think it was already published when the commit was merged to main. My mistake.

@swiatekm
Copy link
Contributor

Ahh never mind, I think it was already published when the commit was merged to main. My mistake.

Yes, instrumentations are published on commit to main. 0.114.0 also has this version as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants