HTTPD instrumentation: Safe modification of httpd.conf #3395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
Include /usr/local/apache2/conf/opentemetry_agent.conf
may be appended on the same line with the last httpd.conf statement, if there is not a blank last line in httpd.conf. This results in a corrupted httpd configuration, and the service will not start.It is safer that an empty line comes before the addition of
Include ...opentemetry_agent.conf
, as a protection measure against such cases.Link to tracking Issue(s): N/A
Testing: Change httpd.conf to not have an blank last line, and then restart the instrumented httpd pod. It fails to start up.
Documentation: N/A