-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate global scrape protocols by allowing for global config setting #3161
Merged
pavolloffay
merged 8 commits into
open-telemetry:main
from
jaronoff97:propagate-global-scrape-protocols
Aug 20, 2024
Merged
Propagate global scrape protocols by allowing for global config setting #3161
pavolloffay
merged 8 commits into
open-telemetry:main
from
jaronoff97:propagate-global-scrape-protocols
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I confirmed that running this new operator version resulted in this response from the scrape_configs endpoint (after setting this in the global config)
|
jaronoff97
added
the
discuss-at-sig
This issue or PR should be discussed at the next SIG meeting
label
Jul 29, 2024
jaronoff97
added
area:collector
Issues for deploying collector
area:target-allocator
Issues for target-allocator
and removed
discuss-at-sig
This issue or PR should be discussed at the next SIG meeting
labels
Aug 15, 2024
swiatekm
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nitpick about the attribute docstring.
pavolloffay
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adjusts the TA CRD to allow for setting the global config
Link to tracking Issue(s):
Testing: unit and e2e
Documentation: