Copy desired Service ports when reconciling #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jpkrohling
previously approved these changes
May 27, 2021
|
Looks good to me: once you confirm that you also don't see any other fields that should be copied, I'll merge. |
jpkrohling
approved these changes
May 27, 2021
|
The However, I think that using the OpenTelemetry Operator, only the |
|
Thank you for this PR! |
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* Copy desired Service ports when reconciling * Fix update service test
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Copy desired Service ports when reconciling * Fix update service test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy services from the desired service when reconciling.
For now it only copies the
portsattribute. We might need to copy additional fields as well. Let me know!Fixes #256
Fixes #295