Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce simplified parsers #2972

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

jaronoff97
Copy link
Contributor

Description:
This is the first part of a multi-PR effort to simplify how parsing configuration blocks works. This is accomplished by massively reducing the toil of creating new parsers and limiting the state objects need to hold on to. Right now, none of these new components are being used, as that will be isolated for a follow up.

Link to tracking Issue(s): #2603

Testing: many unit tests

Documentation: n/a

@jaronoff97 jaronoff97 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 20, 2024
@jaronoff97 jaronoff97 requested a review from a team May 20, 2024 19:10
@jaronoff97
Copy link
Contributor Author

jaronoff97 commented May 20, 2024

Screenshot 2024-05-20 at 3 30 59 PM

This has 100% test coverage where 90% of those tests were copied from the previous package.

Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work. Ping me if you need help for the rest of components

@jaronoff97
Copy link
Contributor Author

@iblancasa can do :D I want to land this, then do exporters, then do processors and then migrate over to use this. You can see an example of the usage here

Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, had some questions, and some comments about style.

internal/components/component.go Outdated Show resolved Hide resolved
internal/components/component.go Outdated Show resolved Hide resolved
internal/components/component.go Outdated Show resolved Hide resolved
internal/components/component.go Outdated Show resolved Hide resolved
internal/components/component.go Outdated Show resolved Hide resolved
internal/components/single_endpoint.go Outdated Show resolved Hide resolved
internal/components/multi_endpoint.go Show resolved Hide resolved
@jaronoff97 jaronoff97 requested review from swiatekm and iblancasa May 30, 2024 15:05
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment on the port parsing notwithstanding.

if r.MatchString(endpoint) {
portStr := r.FindString(endpoint)
cleanedPortStr := strings.Replace(portStr, ":", "", -1)
port, err = strconv.ParseInt(cleanedPortStr, 10, 32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port numbers are 16-bit integers, so this should really be 16 instead of 32. We should also check if the value isn't negative.

In general, is there a reason not to use https://pkg.go.dev/net#SplitHostPort for parsing here, instead of the regex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was copied over from the existing code, but i can swap it :)

Copy link
Contributor Author

@jaronoff97 jaronoff97 May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the problem with net.SplitHostPort is that it doesn't handle the case where it contains a scheme at the beginning (obv not a major issue) but that probably is why it wasn't used initially. The code ends up being the same here actually, so I think I may stick with this just changing to a 16 bit int... actually i think we need to use 32 bits here because otherwise we get an out of range error:

strconv.ParseInt: parsing "65535": value out of range

(ex)

@jaronoff97 jaronoff97 merged commit 4723c17 into open-telemetry:main Jun 3, 2024
33 checks passed
@jaronoff97 jaronoff97 deleted the another-try-sob branch June 5, 2024 15:56
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request Jun 6, 2024
pavolloffay added a commit that referenced this pull request Oct 10, 2024
* Initial commit

* Added Cert Manager CRDs & RBAC validation and management

* Added relevant resources and started adding tests

* Bump github.com/gin-gonic/gin from 1.9.1 to 1.10.0 (#2953)

Bumps [github.com/gin-gonic/gin](https://github.com/gin-gonic/gin) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/gin-gonic/gin/releases)
- [Changelog](https://github.com/gin-gonic/gin/blob/master/CHANGELOG.md)
- [Commits](gin-gonic/gin@v1.9.1...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/gin-gonic/gin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/prometheus/prometheus in the prometheus group (#2951)

Bumps the prometheus group with 1 update: [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus).

Updates `github.com/prometheus/prometheus` from 0.51.2 to 0.52.0
- [Release notes](https://github.com/prometheus/prometheus/releases)
- [Changelog](https://github.com/prometheus/prometheus/blob/main/CHANGELOG.md)
- [Commits](prometheus/prometheus@v0.51.2...v0.52.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/prometheus
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prometheus
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Support for collector readinessProbe (#2944)

* enable readiness Probe for otel operator

Signed-off-by: Janario Oliveira <[email protected]>

* generate CRD and controller changes

Signed-off-by: Janario Oliveira <[email protected]>

* Adjusted code to be similar to Liveness logic

Signed-off-by: Janario Oliveira <[email protected]>

* Generated manifests

Signed-off-by: Janario Oliveira <[email protected]>

* Add changelog

Signed-off-by: Janario Oliveira <[email protected]>

* Fix lint

Signed-off-by: Janario Oliveira <[email protected]>

* Removed readinessProbe from alpha CRD

Signed-off-by: Janario Oliveira <[email protected]>

* Generated manifests

Signed-off-by: Janario Oliveira <[email protected]>

* Fix lint

Signed-off-by: Janario Oliveira <[email protected]>

* Centralized probe validation

Signed-off-by: Janario Oliveira <[email protected]>

---------

Signed-off-by: Janario Oliveira <[email protected]>
Co-authored-by: hesam.hamdarsi <[email protected]>

* Bump github.com/docker/docker (#2954)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 26.0.1+incompatible to 26.0.2+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v26.0.1...v26.0.2)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added new Log Enconder Config (#2927)

* Added new Log Enconder Config

Signed-off-by: Yuri Sa <[email protected]>

* Added new Log Enconder Config

Signed-off-by: Yuri Sa <[email protected]>

* Added new Log Enconder Config

Signed-off-by: Yuri Sa <[email protected]>

* Added new Log Enconder Config

Signed-off-by: Yuri Sa <[email protected]>

* Added new Log Enconder Config

Signed-off-by: Yuri Sa <[email protected]>

* Added new Log Enconder Config

Signed-off-by: Yuri Sa <[email protected]>

* Added new Debug doc

Signed-off-by: Yuri Sa <[email protected]>

---------

Signed-off-by: Yuri Sa <[email protected]>

* [chore] move VineethReddy02 to emeritus (#2957)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Cleanup cluster roles and bindings  (#2938)

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

* Add test

Signed-off-by: Pavol Loffay <[email protected]>

---------

Signed-off-by: Pavol Loffay <[email protected]>

* Fixed non-expected warnings on TA webhook. (#2962)

Signed-off-by: Yuri Sa <[email protected]>

* Verify ServiceMonitor and PodMonitor are installed in prom cr availability check (#2964)

* Verify ServiceMonitor and PodMonitor are installed in prom cr availability check

* Added changelog

* Bump kyverno/action-install-chainsaw from 0.2.0 to 0.2.1 (#2968)

Bumps [kyverno/action-install-chainsaw](https://github.com/kyverno/action-install-chainsaw) from 0.2.0 to 0.2.1.
- [Release notes](https://github.com/kyverno/action-install-chainsaw/releases)
- [Commits](kyverno/action-install-chainsaw@v0.2.0...v0.2.1)

---
updated-dependencies:
- dependency-name: kyverno/action-install-chainsaw
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix labels for Service Monitors (#2878)

* Create a separate Service Monitor when the Prometheus exporter is present

Signed-off-by: Israel Blancas <[email protected]>

* Improve changelog

Signed-off-by: Israel Blancas <[email protected]>

* Fix prometheus-cr E2E test

Signed-off-by: Israel Blancas <[email protected]>

* Remove unused target

Signed-off-by: Israel Blancas <[email protected]>

* Add docstring

Signed-off-by: Israel Blancas <[email protected]>

* Fix typo

Signed-off-by: Israel Blancas <[email protected]>

* Change the label name

Signed-off-by: Israel Blancas <[email protected]>

* Change changelog description

Signed-off-by: Israel Blancas <[email protected]>

* Recover removed labels

Signed-off-by: Israel Blancas <[email protected]>

* Add missing labels

Signed-off-by: Israel Blancas <[email protected]>

* Remove wrong labels

Signed-off-by: Israel Blancas <[email protected]>

---------

Signed-off-by: Israel Blancas <[email protected]>

* Prepare release 0.100.0 (#2960)

* Prepare release 0.100.0

Signed-off-by: Vineeth Pothulapati <[email protected]>

* update the chlog

* update the chlog with #2877 merge

---------

Signed-off-by: Vineeth Pothulapati <[email protected]>

* [chore] Refactor allocation strategies (#2928)

* Refactor consistent-hashing strategy

* Refactor per-node strategy

* Refactor least-weighted strategy

* Minor allocation strategy refactor

* Add some common allocation strategy tests

* Fix collector and target reassignment

* Minor allocator fixes

* Add changelog entry

* Fix an incorrect comment

* Bring back webhook port (#2973)

* add back webhook port

* chlog

* patch 0.100.1 (#2974)

* Update the OpenTelemetry Java agent version to 2.4.0 (#2967)

* simplify deletion logic (#2971)

* Update maintainers in the operator hub PR (#2977)

Signed-off-by: Pavol Loffay <[email protected]>

* Support for kubernetes 1.30 version (#2975)

* Support for kubernetes 1.30 version

* Update makefile

* [chore] Move TargetAllocator CRD to v1alpha1 (#2918)

* [featuregate] Automatically set GOMEMLIMIT and GOMAXPROCS for collector, target allocator, opamp bridge (#2933)

* set things

* fix kustomize shim

* restore, better chlog

* Fix querying OpenShift user workload monitoring stack. (#2984)

* Bump alpine from 3.19 to 3.20 (#2990)

Bumps alpine from 3.19 to 3.20.

---
updated-dependencies:
- dependency-name: alpine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump alpine from 3.19 to 3.20 in /cmd/operator-opamp-bridge (#2991)

Bumps alpine from 3.19 to 3.20.

---
updated-dependencies:
- dependency-name: alpine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/go-logr/logr from 1.4.1 to 1.4.2 (#2987)

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump kyverno/action-install-chainsaw from 0.2.1 to 0.2.2 (#2989)

Bumps [kyverno/action-install-chainsaw](https://github.com/kyverno/action-install-chainsaw) from 0.2.1 to 0.2.2.
- [Release notes](https://github.com/kyverno/action-install-chainsaw/releases)
- [Commits](kyverno/action-install-chainsaw@v0.2.1...v0.2.2)

---
updated-dependencies:
- dependency-name: kyverno/action-install-chainsaw
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the otel group with 5 updates (#2986)

Bumps the otel group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) | `1.26.0` | `1.27.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp](https://github.com/open-telemetry/opentelemetry-go) | `1.26.0` | `1.27.0` |
| [go.opentelemetry.io/otel/metric](https://github.com/open-telemetry/opentelemetry-go) | `1.26.0` | `1.27.0` |
| [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) | `1.26.0` | `1.27.0` |
| [go.opentelemetry.io/otel/sdk/metric](https://github.com/open-telemetry/opentelemetry-go) | `1.26.0` | `1.27.0` |

Updates `go.opentelemetry.io/otel` from 1.26.0 to 1.27.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` from 1.26.0 to 1.27.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0)

Updates `go.opentelemetry.io/otel/metric` from 1.26.0 to 1.27.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0)

Updates `go.opentelemetry.io/otel/sdk` from 1.26.0 to 1.27.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0)

Updates `go.opentelemetry.io/otel/sdk/metric` from 1.26.0 to 1.27.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/metric
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/sdk/metric
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump alpine from 3.19 to 3.20 in /cmd/otel-allocator (#2992)

Bumps alpine from 3.19 to 3.20.

---
updated-dependencies:
- dependency-name: alpine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Keep multiple versions of Collector Config (#2946)

* Prepare v0.101.0 release (#2994)

* Prepare v0.101.0 release

* Undo kustomize stuff

* Undo kustomize stuff again

* Undo kustomize stuff again

* Apply feedback

* Add crd metrics usage information (#2825)

* Add crd metrics usage information

Signed-off-by: Ruben Vargas <[email protected]>

* Add mode metric

Signed-off-by: Ruben Vargas <[email protected]>

* Refactor CR metrics

Signed-off-by: Ruben Vargas <[email protected]>

* Add annotation to avoid generate Metrics

Signed-off-by: Ruben Vargas <[email protected]>

* Add unit tests

Signed-off-by: Ruben Vargas <[email protected]>

* remove space

Signed-off-by: Ruben Vargas <[email protected]>

* remove global provider

Signed-off-by: Ruben Vargas <[email protected]>

* Update main.go

Co-authored-by: Israel Blancas <[email protected]>

* revert kusttomization.yaml

Signed-off-by: Ruben Vargas <[email protected]>

* rename some constants

Signed-off-by: Ruben Vargas <[email protected]>

* Add connectors metrics

Signed-off-by: Ruben Vargas <[email protected]>

* Update chlog

Signed-off-by: Ruben Vargas <[email protected]>

* merge new with init, rename some functions, improve changelog entry

Signed-off-by: Ruben Vargas <[email protected]>

* improve todo comment

Signed-off-by: Ruben Vargas <[email protected]>

* fix tests

Signed-off-by: Ruben Vargas <[email protected]>

* set flag to default false

Signed-off-by: Ruben Vargas <[email protected]>

* fix lint issues

Signed-off-by: Ruben Vargas <[email protected]>

* breaking line

Signed-off-by: Ruben Vargas <[email protected]>

* Use api reader to avoid cache issues

Signed-off-by: Ruben Vargas <[email protected]>

* Add info metric to changelog entry

Signed-off-by: Ruben Vargas <[email protected]>

---------

Signed-off-by: Ruben Vargas <[email protected]>
Co-authored-by: Israel Blancas <[email protected]>

* Update selector documentation for Target Allocator (#3001)

* Bump github.com/prometheus/prometheus in the prometheus group (#3004)

Bumps the prometheus group with 1 update: [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus).


Updates `github.com/prometheus/prometheus` from 0.52.0 to 0.52.1
- [Release notes](https://github.com/prometheus/prometheus/releases)
- [Changelog](https://github.com/prometheus/prometheus/blob/main/CHANGELOG.md)
- [Commits](prometheus/prometheus@v0.52.0...v0.52.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/prometheus
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: prometheus
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump kyverno/action-install-chainsaw from 0.2.2 to 0.2.3 (#3003)

Bumps [kyverno/action-install-chainsaw](https://github.com/kyverno/action-install-chainsaw) from 0.2.2 to 0.2.3.
- [Release notes](https://github.com/kyverno/action-install-chainsaw/releases)
- [Commits](kyverno/action-install-chainsaw@v0.2.2...v0.2.3)

---
updated-dependencies:
- dependency-name: kyverno/action-install-chainsaw
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Introduce simplified parsers (#2972)

* Bump go.opentelemetry.io/otel/exporters/prometheus in the otel group (#3005)

Bumps the otel group with 1 update: [go.opentelemetry.io/otel/exporters/prometheus](https://github.com/open-telemetry/opentelemetry-go).

Updates `go.opentelemetry.io/otel/exporters/prometheus` from 0.48.0 to 0.49.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@example/prometheus/v0.48.0...example/prometheus/v0.49.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/exporters/prometheus
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump go.uber.org/zap from 1.26.0 to 1.27.0 (#3006)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Kafka version in e2e test (#3009)

* [chore] Bump opentelemetry-autoinstrumentation-python to 0.45b0 (#3000)

* chore: Bump opentelemetry-autoinstrumentation-python to 0.45b0

* [chore] add psycopg==0.45b0

* Fix annotation/label filter setting (#3008)

* fix how options are loaded by removing special casing

* oop

* chlog

* update to specific test

* oop

* Added Cert Manager CRDs & RBAC validation and management

* Added relevant resources and started adding tests

* minor change

* Minor change

* minor change

* Cleanup

* Cleanup, go tidy and resolved conflics

* Restored local dev changes

* Refactored, removed init container, minor changes

* Use correct files in TLS config

* Added default value to getHttpsListenAddr

* Added flag to enable mTLS between the Target Allocator and the Collector. go mod cleanup

* Using the enable mTLS flag

* Using feature gate in place of command line flags to enable the feature

* Removed flag from manager yaml

* Added featuregate func description

* Initial unit/e2e tests. some cleanup

* Using TA params

* Cleanup makefile from local changes

* Added step to create cert manager RBAC for e2e mtls tests

* Using Kustomize for patching certmanager permissions

* Cleanup chainsaw test

* Cleanup chainsaw tests

* e2e test case verifying Collector got secret from TA over mTLS

* Added changelog, fixed unit tests

* restored makefile

* Renamed fg import

* Linting rules for imports

* Added more tests, updated the readme

* Added steps in e2e tests for new app

* Ran go mod tidy

* Added new variable to test TA's AddTAConfigToPromConfig

* Setting otel-col-contrib 0.108.0 in e2e test until operator gets updated

* Update pkg/featuregate/featuregate.go

Co-authored-by: Jacob Aronoff <[email protected]>

* Added https, serviceMonitor and tls resources assertions to e2e tests

* Using namespaced names for ClusterRoles

* Cleanup

* Added CertManager resources unit tests

* Added unit tests and e2e assertions

* Added missing assertion call

* Update 00-install.yaml

Removed collector image override for e2e test

* Update pkg/featuregate/featuregate.go

Co-authored-by: Mikołaj Świątek <[email protected]>

* Minor fixes

* Fixed tests referencing logging exporter

* Moved mTLS file naming consts

* Added missing curly bracket

* Update TA-update-configs-to-enable-mtls.yaml

* Update pkg/featuregate/featuregate.go

Co-authored-by: Mikołaj Świątek <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Janario Oliveira <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Vineeth Pothulapati <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Janario Oliveira <[email protected]>
Co-authored-by: hesam.hamdarsi <[email protected]>
Co-authored-by: Yuri Sa <[email protected]>
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Co-authored-by: Pavol Loffay <[email protected]>
Co-authored-by: Aksel Skaar Leirvaag <[email protected]>
Co-authored-by: Israel Blancas <[email protected]>
Co-authored-by: Vineeth Pothulapati <[email protected]>
Co-authored-by: Mikołaj Świątek <[email protected]>
Co-authored-by: Jacob Aronoff <[email protected]>
Co-authored-by: OpenTelemetry Bot <[email protected]>
Co-authored-by: Vasi Vasireddy <[email protected]>
Co-authored-by: Ishwar Kanse <[email protected]>
Co-authored-by: Matt Hagenbuch <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Ruben Vargas <[email protected]>
Co-authored-by: brandonkzw <[email protected]>
Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants