Check labels annotations filter #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
jaronoff97
reviewed
May 3, 2024
| @@ -25,8 +25,9 @@ import ( | |||
| ) | |||
|
|
|||
| func IsFilteredSet(sourceSet string, filterSet []string) bool { | |||
There was a problem hiding this comment.
do we need to compile the pattern here? Is it not enough to just match string on it?
There was a problem hiding this comment.
Theoretically, we shouldn't, but without doing that, the regexp match doesn't work as expected.
There was a problem hiding this comment.
What is the difference between them?
jaronoff97
approved these changes
May 3, 2024
|
@yuriolisa the PR needs to be rebased |
pavolloffay
approved these changes
May 6, 2024
Signed-off-by: Yuri Sa <[email protected]>
swiatekm
approved these changes
May 6, 2024
|
Hi, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing the Labels and Annotations filter.
Link to tracking Issue(s):
Testing:
Documentation: