Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dotnet instr. to command-line #2690

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

luizhlelis
Copy link
Contributor

Description:

change dotnet instrumentation into command line

Link to tracking Issue(s):

Testing:

Documentation:

@luizhlelis luizhlelis marked this pull request as ready for review March 4, 2024 17:39
@luizhlelis luizhlelis requested a review from a team March 4, 2024 17:39
Copy link
Contributor

@yuriolisa yuriolisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes to do. Do you mind adding e2e-tests for auto-instrumentations cli commands?

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@jaronoff97 jaronoff97 merged commit 830a0f7 into open-telemetry:main Mar 5, 2024
29 checks passed
@jaronoff97
Copy link
Contributor

Thank you for your contribution!

ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* chore: update `dotnet` instr. to command-line

* fix: `.NET` pkg instrumentation upgrade

* fix: remove `debug` logs

* fix: pod mutator tests for `.NET` instrumentations

* fix: using capital N for `DotNet`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change instrumentation feature gates into normal command-line flags: operator.autoinstrumentation.dotnet
4 participants