Fixing WATCH_NAMESPACE env variable handling for single namespace value #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dhaja <[email protected]>
jaronoff97
approved these changes
Feb 7, 2024
swiatekm
approved these changes
Feb 7, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dhaja [email protected]
Description:
As mentioned in the linked issue, the
WATCH_NAMESPACEhas no effect in case there is no comma in it (single namespace value).Fixing this by adding entries in the
namespacesmap when theWATCH_NAMESPACEis set and disregarding if it has commas in it or not.Link to tracking Issue: #2589
Testing:
Ran tests locally, verified in a kind cluster that namespaces map contains one item in case
WATCH_NAMESPACEset and no comma in it, and multiple items if the env variable has comma-separated namespaces.Documentation:
N/A