Set update strategy in crd for deployment #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
approved these changes
Jan 14, 2024
Comment on lines
+156
to
+165
| // UpdateStrategy represents the strategy the operator will take replacing existing DaemonSet pods with new pods | ||
| // https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec | ||
| // This is only applicable to Daemonset mode. | ||
| // +optional | ||
| DaemonSetUpdateStrategy appsv1.DaemonSetUpdateStrategy `json:"daemonSetUpdateStrategy,omitempty"` | ||
| // UpdateStrategy represents the strategy the operator will take replacing existing Deployment pods with new pods | ||
| // https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/#DeploymentSpec | ||
| // This is only applicable to Deployment mode. | ||
| // +optional | ||
| DeploymentUpdateStrategy appsv1.DeploymentStrategy `json:"deploymentUpdateStrategy,omitempty"` |
There was a problem hiding this comment.
Is it intentional that we're also adding the DaemonSet setting to v1alpha2? Or is it currently missing?
There was a problem hiding this comment.
I think it's missing by error
There was a problem hiding this comment.
Yeah it was missing. Note, i renamed it though with a daemonset prefix
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Allows a user to set the update strategy for deployments in the collector CRD
Link to tracking Issue: #2512
Testing: Unit tests added
Documentation: api-docs generated