Add Pod securityContext for target allocator #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Husni Alhamdani <[email protected]>
jaronoff97
reviewed
Jan 10, 2024
| @@ -0,0 +1,16 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: breaking | |||
There was a problem hiding this comment.
this is an enhancement as you are adding fields here.
| @@ -51,6 +51,7 @@ spec: | |||
| securityContext: | |||
| runAsUser: 1000 | |||
| runAsGroup: 3000 | |||
| fsGroup: 3000 | |||
There was a problem hiding this comment.
i believe you need to set this in a different block for the podSecurityContext
Signed-off-by: Husni Alhamdani <[email protected]>
husnialhamdani
force-pushed
the
target-allocator-pod-security-context
branch
from
cedd29b to
9ad50fb
Compare
Signed-off-by: Husni Alhamdani <[email protected]>
jaronoff97
reviewed
Jan 10, 2024
| @@ -56,6 +56,8 @@ spec: | |||
| operator: In | |||
| values: | |||
| - "true" | |||
| securityContext: | |||
| runAsUser: 1000 | |||
There was a problem hiding this comment.
should we assert the other properties here too?
runAsGroup: 3000
fsGroup: 2000
Signed-off-by: Husni Alhamdani <[email protected]>
jaronoff97
approved these changes
Jan 10, 2024
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Pod securityContext to target allocator as it was removed in previous changes.
Link to tracking Issue:
#2495
Testing:
Added a unit and E2E test to specifically check fields unique to the Pod security context.