feat/add shareProcessName capability

[bmiguel-teixeira]

Description:
Adding an additional field to the OpenTelemetryCollector CRD called shareProcessNamespace that essentially toggles the equivalent field in the PodSpec of the generated resources (DS, Deployment or STS).

No issue opened on my side.

The reason for this addition in to allow configuration reloads. The OtelCollectors allow config reload via SIGHUP, but there is currently no way to this via the additionalContainers field without this capability.

Testing:

Unit tests added.

Documentation:

[swiatekm]

What do you need the SIGHUP reload for, if I may ask? I'm not opposed to adding this attribute, but reloading config via a signal seems like an antipattern in Kubernetes. We already restart collector Pods whenever configuration changes,

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bmiguel-teixeira / name: Bruno Teixeira (94dd491)

[bmiguel-teixeira]

Hi @swiatekm-sumo

While the bulk of the configuration is indeed static and managed by the controller, a small section of it, the filter section,

  processors:
    filter/md: ${file:/var/conf/extraconf/dynamic.yaml}

is dynamic in our use case and usually varies from cluster to cluster.

P.S: pushed the missing manifests change.

Happy holidays.

[bmiguel-teixeira]

Hi @swiatekm-sumo

Pushed missing changelog file. Any comments/feedback on this?

Ty

[swiatekm]

Could you also set this in one of the E2E tests?

[swiatekm]

@bmiguel-teixeira you've got some failures in the builder unit tests. Other than that, I think we're good to go.

[bmiguel-teixeira]

hi @swiatekm-sumo

Fixed unit tests. Unit and e2e all good locally. ty

[swiatekm]

@bmiguel-teixeira you still have a minor lint issue.

[bmiguel-teixeira]

@swiatekm-sumo done. 🤞

[swiatekm]

LGTM, thanks for your patience!

@jaronoff97 we probably want to add this attribute to common fields as well.

[jaronoff97]

yep, i'll open a follow up issue for that, no need to further block this.