Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing pod in the rbac #2327

Merged
merged 3 commits into from
Nov 27, 2023
Merged

add missing pod in the rbac #2327

merged 3 commits into from
Nov 27, 2023

Conversation

husnialhamdani
Copy link
Member

Description:
Fixing a bug - add missing Pod resources in the RBAC

Link to tracking Issue: #1679

@husnialhamdani husnialhamdani requested a review from a team November 8, 2023 21:35
@jaronoff97 jaronoff97 enabled auto-merge (squash) November 8, 2023 21:38
@husnialhamdani
Copy link
Member Author

the make bundle command was not succesfully executed I guess, should I run that command and push the missing files?

auto-merge was automatically disabled November 8, 2023 21:54

Head branch was pushed to by a user without write access

@jaronoff97
Copy link
Contributor

Yeah give that a shot. There are a few bad files in there for kustomize that you'll need to remove.

@husnialhamdani
Copy link
Member Author

Yeah give that a shot. There are a few bad files in there for kustomize that you'll need to remove.

How do I do/fix that?

frzifus
frzifus reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@frzifus frzifus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix it manually, you can remove the marked lines. Sorry for that bad user experience 😮‍💨 (test-output)

bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated
@@ -31,13 +31,13 @@ metadata:
categories: Logging & Tracing,Monitoring
certified: "false"
containerImage: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator
createdAt: "2023-10-31T11:59:58Z"
createdAt: "2023-11-08T21:42:42Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
createdAt: "2023-11-08T21:42:42Z"

bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated
@@ -452,7 +453,7 @@ spec:
minKubeVersion: 1.23.0
provider:
name: OpenTelemetry Community
version: 0.88.0
version: 0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also revert this line

config/manager/kustomization.yaml Outdated
Comment on lines 3 to 7
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
newName: ghcr.io/hua/opentelemetry-operator/opentelemetry-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
newName: ghcr.io/hua/opentelemetry-operator/opentelemetry-operator

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, also delete this

jaronoff97
jaronoff97 reviewed Nov 9, 2023
View reviewed changes
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated
@@ -452,7 +453,7 @@ spec:
minKubeVersion: 1.23.0
provider:
name: OpenTelemetry Community
version: 0.88.0
version: 0.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also revert this line

config/manager/kustomization.yaml Outdated
Comment on lines 3 to 7
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
newName: ghcr.io/hua/opentelemetry-operator/opentelemetry-operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, also delete this

pavolloffay
pavolloffay requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes referencing hua docker registry

@husnialhamdani
add missing pod in the RBAC
ad53bfe 
Signed-off-by: Husni Alhamdani <[email protected]>
@husnialhamdani
Copy link
Member Author

Reverted back the bad files, could you please check again?

swiatekm
swiatekm reviewed Nov 27, 2023
View reviewed changes
config/manager/kustomization.yaml Outdated
- manager.yaml
- manager.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an unnecessary change. Otherwise LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@husnialhamdani
add missing pod in the rbac
20850f3 
Signed-off-by: Husni Alhamdani <[email protected]>
@husnialhamdani
add missing pod in the rbac
995806b 
Signed-off-by: Husni Alhamdani <[email protected]>
@swiatekm swiatekm requested a review from pavolloffay November 27, 2023 12:13
@pavolloffay pavolloffay merged commit 363f4db into open-telemetry:main Nov 27, 2023
27 checks passed
@pavolloffay pavolloffay mentioned this pull request Nov 27, 2023
Closed
@husnialhamdani
Copy link
Member Author

Thank you all for the review and approval

@husnialhamdani husnialhamdani mentioned this pull request Jan 17, 2024
Closed
6 tasks
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@husnialhamdani
add missing pod in the rbac (open-telemetry#2327)
67ea15c 
* add missing pod in the RBAC

Signed-off-by: Husni Alhamdani <[email protected]>

* add missing pod in the rbac

Signed-off-by: Husni Alhamdani <[email protected]>

* add missing pod in the rbac

Signed-off-by: Husni Alhamdani <[email protected]>

---------

Signed-off-by: Husni Alhamdani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzifus frzifus frzifus approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@swiatekm swiatekm swiatekm approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@husnialhamdani @jaronoff97 @pavolloffay @frzifus @swiatekm