Add permissions for opentelemetry finalizer resource #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you need to generate the manifests again? I would have expected at least the following file to be changed: config/rbac/role.yaml |
Yes, I forgot to re-generate the manifest |
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
fix-ocp-rbac
branch
from
b2cfc5e to
23e862d
Compare
jpkrohling
approved these changes
Mar 1, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
) Signed-off-by: Ruben Vargas <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
) Signed-off-by: Ruben Vargas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test this changes on an OCP cluster, but this should be enough for fix #211
See other similar issues here:
operator-framework/operator-sdk#1736
spotahome/redis-operator#98
Signed-off-by: Ruben Vargas [email protected]