Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation's propagation #1759

Merged

Conversation

yuriolisa
Copy link
Contributor

Fixes #900

The first PR was closed (#1505) in favor to keep the podAnnotations.

@yuriolisa yuriolisa requested a review from a team May 19, 2023 11:18
yuriolisa added 3 commits May 19, 2023 13:23
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaronoff97 jaronoff97 merged commit d111aed into open-telemetry:main May 23, 2023
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Fix annotation's propagation

Signed-off-by: Yuri Sa <[email protected]>

* Added chlog

Signed-off-by: Yuri Sa <[email protected]>

* Changed failling test

Signed-off-by: Yuri Sa <[email protected]>

* Changed failling test

Signed-off-by: Yuri Sa <[email protected]>

---------

Signed-off-by: Yuri Sa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate annotations to Deployment's PodTemplate
3 participants