[target-allocator] Use gin in release mode and without default logger middleware
#1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <[email protected]>
frzifus
approved these changes
Jan 31, 2023
|
Is the issue number mandatory in changelog? 🤔 |
yes :D |
Signed-off-by: Matej Gera <[email protected]>
matej-g
force-pushed
the
adjust-gin-configuration
branch
from
5687302 to
a536862
Compare
|
makes sense to me :) |
jaronoff97
approved these changes
Jan 31, 2023
yuriolisa
approved these changes
Feb 6, 2023
Merged
pavolloffay
approved these changes
Feb 8, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…er middleware (open-telemetry#1414) * Use gin in release mode and without default logger middleware Signed-off-by: Matej Gera <[email protected]> * Add changelog Signed-off-by: Matej Gera <[email protected]> --------- Signed-off-by: Matej Gera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Gera [email protected]
This is a follow-up to #1383.
This PR changes the
ginrouter configuration to be suitable for production use, namely:ginto be used inreleasemode (to my surprise, the default wasdebug)target-allocator.Eventually, it would be nice if we introduced our own logging middleware with formatting consistent with other components, but for now the default one seems noisy and not too useful to me.
cc @kristinapathak