Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add hyperlink to .NET Automatic Instrumentation docs #1344

Closed
wants to merge 2 commits into from
Closed

[chore] Add hyperlink to .NET Automatic Instrumentation docs #1344

wants to merge 2 commits into from

Conversation

pellared
Copy link
Member

  • Add hyperlink to .NET Automatic Instrumentation docs
  • Fix the Node.js "spelling"

@pellared pellared requested a review from a team December 29, 2022 13:38
@pellared pellared changed the title Add hyperlink to .NET Automatic Instrumentation docs [chore] Add hyperlink to .NET Automatic Instrumentation docs Dec 29, 2022
pavolloffay
pavolloffay reviewed Jan 4, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pellared pellared requested a review from pavolloffay January 4, 2023 10:11
@pavolloffay
Copy link
Member

Could you please make sure the changelog CI job is passing?

@pellared
Copy link
Member Author

pellared commented Jan 4, 2023

Could you please make sure the changelog CI job is passing?

Alternately, add either "[chore]" to the title of the pull request or add the "Skip Changelog" label if this job should be skipped.

@pavolloffay
I added [chore] to the title and it is not working 🤷 Can you please add "Skip Changelog" label (I have no permissions)?

@pellared pellared closed this Jan 4, 2023
@pellared pellared reopened this Jan 4, 2023
@pellared
Copy link
Member Author

pellared commented Jan 4, 2023 •
edited
Loading

Reopening the PR triggered the changelog GH workflow 😉

@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 4, 2023
iblancasa
iblancasa requested changes Jan 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pellared pellared requested review from iblancasa and removed request for pavolloffay January 23, 2023 11:44
@Kielek
Copy link
Contributor

Kielek commented Feb 28, 2023

@pavolloffay, do you have a plan to merge it?

@pellared pellared requested a review from pavolloffay March 6, 2023 09:15
@pavolloffay
Copy link
Member

Closing, the changelog now has specific links to the used instrumentation agent versions https://github.com/open-telemetry/opentelemetry-operator/blob/main/CHANGELOG.md#components

@pavolloffay pavolloffay closed this Mar 9, 2023
@pellared pellared deleted the patch-1 branch March 9, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@iblancasa iblancasa iblancasa approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pellared @pavolloffay @Kielek @iblancasa