Apache instrumentation v1.0 #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrlic, @pavolloffay, I would suggest including on that PR, at least the e2e tests. WDYT? |
|
@yuriolisa Since this PR is only about agent image build and does not do the injection itself, I do not see how to test it in the e2e test framework - as far as I can tell, all e2e tests rely currently on pre-build images. My plan was to include e2e test for the final PR. But, if you have a suggestion in this direction, I'm open to that. |
pavolloffay
reviewed
Nov 14, 2022
autoinstrumentation/apache/README.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| # How to build Apache auto-instrumentation docker image | |||
There was a problem hiding this comment.
can we come up with a more explicit name (for the directory/image/readme name)? Apache is just too generic
…ic/opentelemetry-operator into apache-instrumentation-v1.0
|
Renamed the "apache" to "apache-httpd" |
pavolloffay
approved these changes
Nov 22, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Apache Instrumentation - Agent Image Build * Rename deafult image name * Github bld action for Apache HTTPD autoinstr img * Added Apache HTTPD image to publish images act * Heading change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes auto-instrumentation for applications running on Apache HTTPD server in K8S environment.
It also replaces earlier submitted PR #1082
For instrumentation library, the logic provided here uses https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/instrumentation/otel-webserver-module
For instrumentation logic itself, it adheres to the principles used for other languages already supported as much as possible.
This PR is a first in a series as discussed in #1082 and provides a method for building an image with webserver agent libraries.
Next PR will provide CRD for Apache auto-instrumentation specification and related code.
And next PR will provide the code for auto-instrumentation logic within mutating webhook, related code, and end2end tests.