Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error logs to info for building container #1146

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

kristinapathak
Copy link
Contributor

fixes #1143
error logs include stacktraces - changing the level to info means a stacktrace is not included.
error:

{"level":"error","ts":1665093234.6714225,"logger":"controllers.OpenTelemetryCollector",
"msg":"couldn't determine metrics port from configuration, using 8888 default value",
"opentelemetrycollector":"opentelemetry/lightstep-collector","error":"missing port in address",
"stacktrace":"github.com/open-telemetry/opentelemetry-operator/pkg/collector.getConfigContainerPorts\n
\t/workspace/pkg/collector/container.go:171\ngithub.com/open-telemetry/opentelemetry-operator/pkg/collector.Container\n
\t/workspace/pkg/collector/container.go:49\ngithub.com/open-telemetry/opentelemetry-operator/pkg/collector.Deployment\n
\t/workspace/pkg/collector/deployment.go:55\ngithub.com/open-telemetry/opentelemetry-operator/pkg/collector/reconcile.Deployments\n
\t/workspace/pkg/collector/reconcile/deployment.go:38\n
github.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).RunTasks\n
\t/workspace/controllers/opentelemetrycollector_controller.go:164\n
github.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).Reconcile\n
\t/workspace/controllers/opentelemetrycollector_controller.go:154\n
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n
\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:121\n
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n
\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:320\n
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n
\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:273
\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n
\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:234"}

info:

{"level":"info","ts":1665095324.665596,"logger":"controllers.OpenTelemetryCollector",
"msg":"couldn't determine metrics port from configuration, using 8888 default value",
"opentelemetrycollector":"opentelemetry/lightstep-collector","error":"missing port in address"}

@kristinapathak kristinapathak requested a review from a team October 6, 2022 22:34
@pavolloffay pavolloffay changed the title change error logs to info for building container Change error logs to info for building container Oct 7, 2022
@pavolloffay pavolloffay merged commit 32464ac into open-telemetry:main Oct 7, 2022
@kristinapathak kristinapathak deleted the logger-panic branch October 7, 2022 16:43
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] OpenTelemetryCollector reconcile loop panics
2 participants