Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconcile otel collector on given context #1144

Merged
merged 1 commit into from
Oct 6, 2022
Merged

reconcile otel collector on given context #1144

merged 1 commit into from
Oct 6, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Oct 6, 2022

Saw randomly that a new context is created in the reconciler. Or is there a reason for this?

@frzifus frzifus requested a review from a team October 6, 2022 13:47
pavolloffay
pavolloffay approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pavolloffay pavolloffay merged commit c9a6505 into open-telemetry:main Oct 6, 2022
@frzifus frzifus deleted the reconcile_on_given_ctx branch October 6, 2022 14:52
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@frzifus
Continue context in the collector controller (open-telemetry#1144)
a180bac 
Signed-off-by: Benedikt Bongartz <[email protected]>

Signed-off-by: Benedikt Bongartz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frzifus @pavolloffay