Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deepcopy missing implementation for TargetCPUUtilization field of AutoscalerSpec #1138

Conversation

avadhut123pisal
Copy link
Contributor

After running make generate , found some code that is not committed yet to the repo, adding the same.

@avadhut123pisal avadhut123pisal requested a review from a team October 4, 2022 16:03
@avadhut123pisal avadhut123pisal changed the title adds deepcopy missing implementation for TargetCPUUtilization field of AutoscalerSpec Adds deepcopy missing implementation for TargetCPUUtilization field of AutoscalerSpec Oct 4, 2022
@avadhut123pisal avadhut123pisal force-pushed the missing-deepcopy-code-for-TargetCPUUtilization branch from 452c44d to aec7b0c Compare October 7, 2022 04:27
@pavolloffay
Copy link
Member

I am not sure how PR without missing generated code could have been committed. There should be a CI check to avoid merging this.

@avadhut123pisal avadhut123pisal force-pushed the missing-deepcopy-code-for-TargetCPUUtilization branch from aec7b0c to 59e0993 Compare October 7, 2022 13:01
@pavolloffay
Copy link
Member

#1154 fixes the check

@pavolloffay pavolloffay merged commit a029af7 into open-telemetry:main Oct 10, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants