-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument TA with prometheus #1030
Merged
pavolloffay
merged 5 commits into
open-telemetry:main
from
jaronoff97:target-allocator-metrics
Aug 15, 2022
Merged
Instrument TA with prometheus #1030
pavolloffay
merged 5 commits into
open-telemetry:main
from
jaronoff97:target-allocator-metrics
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
requested changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First quick pass
secustor
approved these changes
Aug 12, 2022
Aneurysm9
approved these changes
Aug 12, 2022
pavolloffay
approved these changes
Aug 15, 2022
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Instrument TA with prometheus * Added metrics for targets per collector * Remove auth line * Updated based on feedback * Small exporting change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1029 by adding in instrumentation for the target allocator through Prometheus. The amount of metrics was kept to be minimal so that we can migrate this to use the otel go SDK in the future. The current implementation adds a prometheus endpoint
/metrics
to the existing:8080
port. It also adds in a mux middleware to track some metrics about requests made to the endpoints.Metrics Reported