Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service account is created even when one is specified in targetallocator spec #2443

Closed
swiatekm opened this issue Dec 14, 2023 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@swiatekm
Copy link
Contributor

swiatekm commented Dec 14, 2023

Component(s)

target allocator

What happened?

Description

The operator creates a ServiceAccount for the Target Allocator even if spec.targetAllocator.serviceAccount is set. This is basically the same bug as #2372, but for the Target Allocator manifests.

Kubernetes Version

1.27

Operator version

0.90.0

Collector version

0.90.1

@swiatekm
Copy link
Contributor Author

Looks like if we don't set the ServiceAccount on the target allocator, the generated name is wrong as well. So this whole area is just borked.

@jaronoff97
Copy link
Contributor

🤦 @swiatekm-sumo would you be able to get this in prior to #2443

@swiatekm
Copy link
Contributor Author

Prior to this very issue, @jaronoff97? I am very talented, but not yet a time traveler.

But yeah, I can do it before the next release.

@jaronoff97
Copy link
Contributor

🤦 this is what i get for bad typing!! i meant to do #2433 😓 i was 10 off 😆

@swiatekm
Copy link
Contributor Author

Fixed in #2445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants