Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apacheModuleServiceNamespace takes one argument, Logical namespace of the service #1893

Closed
gioppoluca opened this issue Jul 5, 2023 · 3 comments
Labels
area:auto-instrumentation Issues for auto-instrumentation auto-instrumentation:apache-httpd bug Something isn't working

Comments

@gioppoluca
Copy link

Seems that the template added by the agent in apache httpd is missing one argument.
This is the template placed in the OTEL_APACHE_AGENT_CONF does not contain any argument in the ApacheModuleServiceNamespace

        - name: OTEL_APACHE_AGENT_CONF
          value: >

            #Load the Otel Webserver SDK

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_common.so

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_resources.so

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_trace.so

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_otlp_recordable.so

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_exporter_ostream_span.so

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_exporter_otlp_grpc.so

            #Load the Otel ApacheModule SDK

            LoadFile
            /opt/opentelemetry-webserver/agent/sdk_lib/lib/libopentelemetry_webserver_sdk.so

            #Load the Apache Module. In this example for Apache 2.4

            #LoadModule otel_apache_module
            /opt/opentelemetry-webserver/agent/WebServerModule/Apache/libmod_apache_otel.so

            #Load the Apache Module. In this example for Apache 2.2

            #LoadModule otel_apache_module
            /opt/opentelemetry-webserver/agent/WebServerModule/Apache/libmod_apache_otel22.so

            LoadModule otel_apache_module
            /opt/opentelemetry-webserver/agent/WebServerModule/Apache/libmod_apache_otel.so

            #Attributes

            ApacheModuleEnabled ON

            ApacheModuleOtelExporterEndpoint
            http://elastic-collector.opentelemetry.svc:4317

            ApacheModuleOtelSpanExporter otlp

            ApacheModuleResolveBackends  ON

            ApacheModuleServiceInstanceId <<SID-PLACEHOLDER>>

            ApacheModuleServiceName testhttpd

            ApacheModuleServiceNamespace 

            ApacheModuleTraceAsError  ON

Where can this be fixed?

@TylerHelmuth TylerHelmuth added bug Something isn't working area:auto-instrumentation Issues for auto-instrumentation auto-instrumentation:apache-httpd labels Jul 5, 2023
@pavolloffay
Copy link
Member

cc) @chrlic

@chrlic
Copy link
Member

chrlic commented Jul 6, 2023

It should be assigned the name of the namespace of the pod. Could you post your workload manifest?

Before I fix it - as a workaround, in the Instrumentation crd, attribute values can be overriden with attrs setting, example at https://github.com/open-telemetry/opentelemetry-operator#using-apache-httpd-autoinstrumentation

chrlic added a commit to chrlic/opentelemetry-operator that referenced this issue Jul 11, 2023
jaronoff97 added a commit that referenced this issue Jul 12, 2023
…ntation request namespace name or static default name (#1905)

* fix for #1893

* chloggen

---------

Co-authored-by: Jacob Aronoff <[email protected]>
@yuriolisa
Copy link
Contributor

@jaronoff97, I believe this issue can be closed, right?

ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this issue May 1, 2024
…ck to instrumentation request namespace name or static default name (open-telemetry#1905)

* fix for open-telemetry#1893

* chloggen

---------

Co-authored-by: Jacob Aronoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auto-instrumentation Issues for auto-instrumentation auto-instrumentation:apache-httpd bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants