-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTEL Operator adds un-needed default volume for StatefulSet #1281
Comments
As ref disussion on #otel-operator it should not be needed for the StatefulSet according to previous discussions and doc to have a PVC attached. https://docs.google.com/document/d/1KO9mQf9owbEsxYMe1yevwEOo5S-J0AE3g3HZyY5fZMo/edit# |
ekarlso
added a commit
to ekarlso/opentelemetry-operator
that referenced
this issue
Nov 27, 2022
ekarlso
added a commit
to ekarlso/opentelemetry-operator
that referenced
this issue
Nov 29, 2022
ekarlso
added a commit
to ekarlso/opentelemetry-operator
that referenced
this issue
Nov 29, 2022
pavolloffay
pushed a commit
that referenced
this issue
Nov 30, 2022
ihalaij1
pushed a commit
to ihalaij1/opentelemetry-operator
that referenced
this issue
Dec 8, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this issue
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you add a collector that has mode statefulset it will have a default volume added which is not-needed for a simple deployment unless you want to actively store state on a disk.
Here is the test for the functionality in question
opentelemetry-operator/pkg/collector/volumeclaim_test.go
Line 30 in 57abb4d
Here is the code actually adding a PVC if there are none defined by the user (causing deployments where you don't want it to get it)
opentelemetry-operator/pkg/collector/volumeclaim.go
Line 37 in 57abb4d
The text was updated successfully, but these errors were encountered: