Use api reader to avoid cache issues

Signed-off-by: Ruben Vargas <[email protected]>
open-telemetry · May 30, 2024 · f16d7ef · f16d7ef
1 parent b1d33cc
commit f16d7ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/apis/v1beta1/metrics.go b/apis/v1beta1/metrics.go
@@ -72,7 +72,7 @@ func BootstrapMetrics() (metric.MeterProvider, error) {
 	return sdkmetric.NewMeterProvider(sdkmetric.WithReader(exporter)), err
 }
 
-func NewMetrics(prv metric.MeterProvider, ctx context.Context, cl client.Client) (*Metrics, error) {
+func NewMetrics(prv metric.MeterProvider, ctx context.Context, cl client.Reader) (*Metrics, error) {
 	meter := prv.Meter(meterName)
 	modeCounter, err := meter.Int64UpDownCounter(modeMetricName)
 	if err != nil {
@@ -120,7 +120,7 @@ func NewMetrics(prv metric.MeterProvider, ctx context.Context, cl client.Client)
 }
 
 // Init metrics from the first time the operator starts.
-func (m *Metrics) init(ctx context.Context, cl client.Client) error {
+func (m *Metrics) init(ctx context.Context, cl client.Reader) error {
 	opts := []client.ListOption{
 		client.MatchingLabels(map[string]string{
 			"app.kubernetes.io/managed-by": "opentelemetry-operator",

diff --git a/main.go b/main.go
@@ -384,9 +384,9 @@ func main() {
 				setupLog.Error(metricsErr, "Error bootstrapping CRD metrics")
 			}
 
-			crdMetrics, err = otelv1beta1.NewMetrics(meterProvider, ctx, mgr.GetClient())
+			crdMetrics, err = otelv1beta1.NewMetrics(meterProvider, ctx, mgr.GetAPIReader())
 			if err != nil {
-				setupLog.Error(err, "Error bootstrapping CRD metrics")
+				setupLog.Error(err, "Error init CRD metrics")
 			}
 
 		}