Skip to content

Commit

Permalink
Add changelog
Browse files Browse the repository at this point in the history
Signed-off-by: Janario Oliveira <[email protected]>
  • Loading branch information
janario committed Apr 5, 2024
1 parent 896b534 commit b42f7c6
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions .chloggen/add-service-instance-id.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action)
component: auto-instrumentation

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add attribute `service.instance.id` while pod is mutated.

# One or more tracking issues related to the change
issues: [2679]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
`service.instance.id` is expected to be `<namespace>.<podName>.<containerName>`
But while pod is created it may not have the `podName` yet at the podMutator webhooks.
This changed to use the env var `OTEL_RESOURCE_ATTRIBUTES_POD_NAME` which will be present at runtime.
`<namespace>.$(OTEL_RESOURCE_ATTRIBUTES_POD_NAME).<containerName>`
Making a valid and complete value for `service.instance.id` to be added.

0 comments on commit b42f7c6

Please sign in to comment.