Only add fallbackstrategy if nonempty

open-telemetry · Nov 22, 2024 · 0254654 · 0254654
1 parent 7d32f7e
commit 0254654
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/cmd/otel-allocator/main.go b/cmd/otel-allocator/main.go
@@ -81,7 +81,13 @@ func main() {
 	log := ctrl.Log.WithName("allocator")
 
 	allocatorPrehook = prehook.New(cfg.FilterStrategy, log)
-	allocator, err = allocation.New(cfg.AllocationStrategy, log, allocation.WithFilter(allocatorPrehook), allocation.WithFallbackStrategy(cfg.AllocationFallbackStrategy))
+
+	var allocationOptions []allocation.AllocationOption
+	allocationOptions = append(allocationOptions, allocation.WithFilter(allocatorPrehook))
+	if cfg.AllocationFallbackStrategy != "" {
+		allocationOptions = append(allocationOptions, allocation.WithFallbackStrategy(cfg.AllocationFallbackStrategy))
+	}
+	allocator, err = allocation.New(cfg.AllocationStrategy, log, allocationOptions...)
 	if err != nil {
 		setupLog.Error(err, "Unable to initialize allocation strategy")
 		os.Exit(1)