makefile add license check support

[wph95]

resolved #39

[djaglowski]

When I run make ci-check, I get some errors on generated files:

make ci-check
GOOS=darwin /Library/Developer/CommandLineTools/usr/bin/make for-all CMD="go vet ./..."
GOOS=linux /Library/Developer/CommandLineTools/usr/bin/make for-all CMD="go vet ./..."
GOOS=windows /Library/Developer/CommandLineTools/usr/bin/make for-all CMD="go vet ./..."
golangci-lint run ./...
addlicense FAILED => add License errors:

./testutil/operator_builder.go
./testutil/pipeline.go
./testutil/database.go
./testutil/operator.go

Use 'make add-license' to fix this.
make: *** [check-license] Error 1

@tigrannajaryan Is it an acceptable approach to exclude these files from the license check?

[wph95]

if want ignore testutil/*
just change makefile ALL_SRC like https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/Makefile.Common#L5

[djaglowski]

I think that this PR should include making all the license checks pass, so we should include the change here. Do you mind adding?

[djaglowski]

We need to figure out how to make use of the tooling packages without including them in the module file.

[djaglowski]

I don't think we need to include these in the module, and believe we should try not to.

Neither the collector or collector-contrib repos have needed these in go.mod.

[djaglowski]

This is a lot of extras that I can't reconcile. Can you try regenerating this after addressing the go.mod comment?

[tigrannajaryan]

When I run make ci-check, I get some errors on generated files:

make ci-check
GOOS=darwin /Library/Developer/CommandLineTools/usr/bin/make for-all CMD="go vet ./..."
GOOS=linux /Library/Developer/CommandLineTools/usr/bin/make for-all CMD="go vet ./..."
GOOS=windows /Library/Developer/CommandLineTools/usr/bin/make for-all CMD="go vet ./..."
golangci-lint run ./...
addlicense FAILED => add License errors:

./testutil/operator_builder.go
./testutil/pipeline.go
./testutil/database.go
./testutil/operator.go

Use 'make add-license' to fix this.
make: *** [check-license] Error 1

@tigrannajaryan Is it an acceptable approach to exclude these files from the license check?

@djaglowski Yes, we normally exclude generated files from license checks.