Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

syslog_input config embed syslog_parser inline #43

Merged
merged 4 commits into from
Mar 3, 2021
Merged

syslog_input config embed syslog_parser inline #43

merged 4 commits into from
Mar 3, 2021

Conversation

wph95
Copy link
Member

@wph95 wph95 commented Mar 2, 2021

resolved #34

djaglowski
djaglowski approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small note on the tests.

operator/builtin/input/syslog/syslog_test.go Outdated Show resolved Hide resolved
@djaglowski djaglowski merged commit fb7443a into open-telemetry:main Mar 3, 2021
@wph95 wph95 deleted the improve-syslog-input-config branch March 5, 2021 05:21
@wph95 wph95 restored the improve-syslog-input-config branch March 5, 2021 05:21
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syslog_input should embed syslog_parser inline
2 participants
@wph95 @djaglowski