Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

CSV Added 'Lazy Quotes' support #324

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Dec 2, 2021

Added configuration for Lazy Quotes that passes through to the CSV reader.

Support a string like "one",two,three will parse as "one", two, three with lazy_quotes enabled.

@cpheps cpheps requested a review from a team December 2, 2021 17:56
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@djaglowski
Copy link
Member

Seems reasonable. Can you add the parameter to the documentation?

@cpheps
Copy link
Contributor Author

cpheps commented Dec 6, 2021

Yeah will do, overlooked that.

@djaglowski
Copy link
Member

/easycla

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #324 (ac76bcf) into main (d86516e) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #324     +/-   ##
=======================================
- Coverage   77.0%   77.0%   -0.1%     
=======================================
  Files         94      94             
  Lines       4410    4412      +2     
=======================================
- Hits        3400    3399      -1     
- Misses       695     697      +2     
- Partials     315     316      +1     
Impacted Files Coverage Δ
operator/builtin/parser/csv/csv.go 97.5% <100.0%> (+0.1%) ⬆️
operator/builtin/input/file/file.go 72.3% <0.0%> (-1.9%) ⬇️

@djaglowski djaglowski merged commit d79bfca into open-telemetry:main Dec 20, 2021
@djaglowski djaglowski deleted the csv-lazy-quote-config branch December 20, 2021 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants