This repository has been archived by the owner on May 25, 2022. It is now read-only.
fix(recombine)!: change default operator type #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When declaring a `recombine` operator in configuration without specifying the `id`, the default operator ID is `metadata`. This can cause issues when user configures both an actual `metadata` operator and `recombine` operator, both of them without their `id`s. BREAKING CHANGE: The default operator ID for `recombine` operator is now `recombine`, not `metadata`.
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
=====================================
Coverage 77.0% 77.0%
=====================================
Files 94 94
Lines 4408 4408
=====================================
Hits 3395 3395
Misses 697 697
Partials 316 316
|
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a small inconsistency that I've found in the
recombineoperator. Can we fix it? Note that it is technically a breaking change.When declaring a
recombineoperator in configuration without specifying theid, the default operator ID ismetadata. I imagine this can cause issues when user configures both an actualmetadataoperator andrecombineoperator, both of them without theirids.BREAKING CHANGE: The default operator ID for
recombineoperator is nowrecombine, notmetadata.