This repository has been archived by the owner on May 25, 2022. It is now read-only.
Improve no timezone db error #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
changed the title
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=======================================
+ Coverage 76.8% 77.0% +0.1%
=======================================
Files 94 94
Lines 4410 4410
=======================================
+ Hits 3391 3397 +6
+ Misses 700 697 -3
+ Partials 319 316 -3
|
djaglowski
reviewed
Oct 12, 2021
| @@ -75,7 +75,7 @@ func (c SyslogParserConfig) Build(context operator.BuildContext) ([]operator.Ope | |||
|
|
|||
| location, err := time.LoadLocation(c.Location) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, fmt.Errorf("failed to load location %s (is the timezone database installed?): %w", c.Location, err) | |||
There was a problem hiding this comment.
I can appreciate what you're getting at here, but an error message that asks a question is unusual. More importantly, I suspect this will be a red herring in the majority of cases, since the most common cause of this error will be users specifying an invalid location.
There was a problem hiding this comment.
For context, on Windows, the timezone database is generally not present. While on Linux it is common to have the tzdata package installed by default.
There was a problem hiding this comment.
Yeah, I was kinda iffy on about putting that in there, too. I'll take the question out. Knowing that it failed to load the location should probably be enough to debug.
djaglowski
added a commit
to djaglowski/opentelemetry-log-collection
that referenced
this pull request
Nov 30, 2021
- `combine_with` setting to `recombine` operator, to allow for joining on custom delimiter ([PR315](open-telemetry#315)) - Issue where `force_flush_period` could cause line splitting to be skipped ([PR303](open-telemetry#303)) - Issue where `tcp_input` and `udp_input` could panic when stopping ([PR273](open-telemetry#273)) - Syslog severity mapping is now aligned with log specification ([PR300](open-telemetry#300)) - Improve error message when timezone database is not found ([PR289](open-telemetry#289))
djaglowski
added a commit
that referenced
this pull request
Nov 30, 2021
- `combine_with` setting to `recombine` operator, to allow for joining on custom delimiter ([PR315](#315)) - Issue where `force_flush_period` could cause line splitting to be skipped ([PR303](#303)) - Issue where `tcp_input` and `udp_input` could panic when stopping ([PR273](#273)) - Syslog severity mapping is now aligned with log specification ([PR300](#300)) - Improve error message when timezone database is not found ([PR289](#289))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #288
This PR wraps the error returned from time.LoadLocation to include that a location was trying to be loaded, and that the timezone database may not be present.