Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

URI Parser Tests #281

Merged
merged 2 commits into from
Sep 27, 2021
Merged

URI Parser Tests #281

merged 2 commits into from
Sep 27, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Sep 25, 2021

  • added golden config tests
  • added tests for process
  • test coverage 93% -> 100%
  • bumped code cov go version from 1.15 to 1.17. It appears Go 1.15 does not fail to parse invalid URI's the way Go 1.17 does.

@jsirianni jsirianni requested a review from a team September 25, 2021 21:08
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #281 (aafcada) into main (192c163) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #281   +/-   ##
=====================================
  Coverage   76.4%   76.4%           
=====================================
  Files         95      95           
  Lines       4454    4454           
=====================================
+ Hits        3404    3406    +2     
+ Misses       719     718    -1     
+ Partials     331     330    -1     
Impacted Files Coverage Δ
operator/builtin/input/tcp/tcp.go 72.9% <0.0%> (-1.7%) ⬇️
operator/builtin/parser/uri/uri.go 100.0% <0.0%> (+8.1%) ⬆️

@jsirianni jsirianni merged commit c841217 into open-telemetry:main Sep 27, 2021
@jsirianni jsirianni deleted the uri-parser-test-coverage branch September 27, 2021 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants