Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Increase time_parser's test coverage #280

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Increase time_parser's test coverage #280

merged 1 commit into from
Sep 27, 2021

Conversation

jsirianni
Copy link
Member

Increased test coverage from 66.7% to 100%. 66% coverage is somewhat misleading as the existing test cases are very thorough when it comes to testing various time formats and inputs. Some coverage was missing for Build and Process.

@jsirianni jsirianni requested a review from a team September 25, 2021 18:45
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #280 (e2c3907) into main (192c163) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #280     +/-   ##
=======================================
+ Coverage   76.4%   76.5%   +0.1%     
=======================================
  Files         95      95             
  Lines       4454    4454             
=======================================
+ Hits        3404    3409      +5     
+ Misses       719     716      -3     
+ Partials     331     329      -2     
Impacted Files Coverage Δ
operator/builtin/parser/time/time.go 100.0% <0.0%> (+33.3%) ⬆️

@jsirianni jsirianni merged commit e440b7a into open-telemetry:main Sep 27, 2021
@jsirianni jsirianni deleted the time-parser-test-coverage branch September 27, 2021 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants