This repository has been archived by the owner on May 25, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #227
Two additional notes on this implementation:
Default
A
default
severity level is (still) supported. I considered allowing users to set a "default default", but there isn't a clear single point of configuration for such a setting. For now, I've just left it in place, and it can continue to be handled in the collector'sinternal/stanza/converter.go
.Custom Levels
Since all severity levels in this design are named, there is no need to support custom integer severity levels. The only impact of this that some mapping validation code could be removed, and some associated test cases were invalided.