Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Fully adopt OTel severity system #228

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

djaglowski
Copy link
Member

Resolves: #227

Two additional notes on this implementation:

Default

A default severity level is (still) supported. I considered allowing users to set a "default default", but there isn't a clear single point of configuration for such a setting. For now, I've just left it in place, and it can continue to be handled in the collector's internal/stanza/converter.go.

Custom Levels

Since all severity levels in this design are named, there is no need to support custom integer severity levels. The only impact of this that some mapping validation code could be removed, and some associated test cases were invalided.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #228 (6fe0737) into main (038b640) will decrease coverage by 0.2%.
The diff coverage is 91.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #228     +/-   ##
=======================================
- Coverage   75.9%   75.7%   -0.3%     
=======================================
  Files         95      95             
  Lines       4476    4450     -26     
=======================================
- Hits        3398    3369     -29     
- Misses       749     751      +2     
- Partials     329     330      +1     
Impacted Files Coverage Δ
logger/parser.go 47.8% <0.0%> (ø)
operator/builtin/parser/syslog/data.go 89.4% <ø> (ø)
operator/builtin/parser/syslog/syslog.go 67.8% <ø> (ø)
entry/severity.go 66.6% <100.0%> (-33.4%) ⬇️
operator/builtin/input/windows/xml.go 82.6% <100.0%> (ø)
operator/helper/severity_builder.go 85.7% <100.0%> (+0.2%) ⬆️
operator/builtin/parser/severity/severity.go 60.0% <0.0%> (-13.4%) ⬇️
operator/helper/severity.go 71.7% <0.0%> (-10.3%) ⬇️

@djaglowski djaglowski marked this pull request as ready for review July 26, 2021 19:58
@djaglowski djaglowski requested a review from a team July 26, 2021 19:58
@jsirianni jsirianni self-requested a review July 27, 2021 13:52
@djaglowski djaglowski merged commit 87e9ee2 into open-telemetry:main Jul 27, 2021
@djaglowski djaglowski deleted the otel-levels-sev-mapping branch July 27, 2021 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for non-OTel severity levels
2 participants