This repository has been archived by the owner on May 25, 2022. It is now read-only.
File input should not complain about files already being closed #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=======================================
- Coverage 75.6% 75.6% -0.1%
=======================================
Files 95 95
Lines 4362 4363 +1
=======================================
- Hits 3301 3300 -1
- Misses 738 739 +1
- Partials 323 324 +1
|
|
#175 Fixes codecov config. Will rebase when it is merged. |
djaglowski
force-pushed
the
quiet-close-error
branch
from
db69ec2 to
dbc74b6
Compare
jsirianni
approved these changes
Jun 9, 2021
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File input generates errors when closing files, because they are being closed twice.