This repository has been archived by the owner on May 25, 2022. It is now read-only.
Add test that validates fingerprint.StartsWith when read from files #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
approved these changes
May 18, 2021
| @@ -212,4 +214,49 @@ func TestFingerprintStartsWith(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestFingerprintStartsWith_FromFile(t *testing.T) { | |||
| rand.Seed(112358) | |||
There was a problem hiding this comment.
This global may not work well if tests are run in parallel (do we?).
r := rand.New(rand.NewSource(112358)) and using r.Read() should be safer.
| @@ -212,4 +214,49 @@ func TestFingerprintStartsWith(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestFingerprintStartsWith_FromFile(t *testing.T) { | |||
There was a problem hiding this comment.
I am not familiar with what the fingerprints and how they work so I don't understand what this test does. Perhaps that's fine and I am not supposed to understand. If you want me to understand though please add some comments to explain what it does :-)
There was a problem hiding this comment.
It's certainly not meant to be a secret. :)
I expanded the comments on the Fingerprint struct and its StartsWith method, and also added a high level explanation on the new test.
tigrannajaryan
approved these changes
May 19, 2021
jsirianni
added a commit
to observIQ/stanza
that referenced
this pull request
May 25, 2021
4 tasks
jsirianni
pushed a commit
to observIQ/stanza
that referenced
this pull request
May 26, 2021
* Add test that validates fingerprint.StartsWith when read from files, from open-telemetry/opentelemetry-log-collection#145 * close files in fingerprint test: https://github.com/observIQ/opentelemetry-log-collection/commit/42931ada82ef26fde2c6e62e6fa9495997bee2cd\#diff-73ecab0b12cec8730ffb8cc5a54d0d1468d7b8c1f2be318a481490402deacc30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.