Port CSV operator from stanza #123

Mrod1598 · 2021-04-27T15:20:37Z

resolves #73

operator/builtin/parser/csv/csv_test.go

docs/operators/csv_parser.md

operator/builtin/parser/csv/csv.go

operator/builtin/parser/csv/testdata/delimiter.yaml

operator/builtin/parser/csv/testdata/basic.yaml

operator/builtin/parser/csv/testdata/timestamp.yaml

operator/builtin/parser/csv/csv.go

operator/builtin/parser/csv/testdata/delimiter.yaml

operator/builtin/parser/csv/testdata/basic.yaml

operator/builtin/parser/csv/csv.go

operator/builtin/parser/csv/testdata/delimiter.yaml

operator/builtin/parser/csv/testdata/timestamp.yaml

djaglowski

Looking pretty good. Also reviewed the docs and tests this time.

operator/builtin/parser/csv/csv.go

docs/operators/csv_parser.md

operator/builtin/parser/csv/csv_test.go

operator/builtin/parser/csv/csv.go

djaglowski

This looks great. Just a couple doc comments.

docs/operators/csv_parser.md

djaglowski

Thanks @Mrod1598

Port CSV operator from stanza

94b17fd

Mrod1598 requested a review from a team April 27, 2021 15:20

Fix lint issues

29c1387

jsirianni suggested changes Apr 27, 2021

View reviewed changes

operator/builtin/parser/csv/csv_test.go Outdated Show resolved Hide resolved

Update test

8d65493

jsirianni self-requested a review April 30, 2021 17:41

jsirianni approved these changes Apr 30, 2021

View reviewed changes

djaglowski suggested changes May 7, 2021

View reviewed changes

Implement PR feedback and Add comment for clarity

27ebf4c

djaglowski suggested changes May 10, 2021

View reviewed changes

Update Header Handling and more quoting

779b104

Mrod1598 commented May 11, 2021

View reviewed changes

operator/builtin/parser/csv/testdata/delimiter.yaml Show resolved Hide resolved

Mrod1598 commented May 11, 2021

View reviewed changes

operator/builtin/parser/csv/testdata/timestamp.yaml Show resolved Hide resolved

djaglowski reviewed May 11, 2021

View reviewed changes

Remove Comment

b129307

djaglowski reviewed May 13, 2021

View reviewed changes

operator/builtin/parser/csv/csv.go Outdated Show resolved Hide resolved

operator/builtin/parser/csv/csv.go Show resolved Hide resolved

Mrod1598 added 6 commits May 13, 2021 18:17

Implement PR feedback

582c837

Force CI

b4f08cf

Fix location parsing

296b2de

Force CI

7acc432

Change location

f0aefed

Force CI

09b6fa8

djaglowski reviewed May 17, 2021

View reviewed changes

Mrod1598 added 2 commits May 17, 2021 15:00

Update docs

f722890

Update doc

b88a7a5

djaglowski approved these changes May 17, 2021

View reviewed changes

djaglowski merged commit 2ccc307 into open-telemetry:main May 17, 2021

djaglowski deleted the csv-operator branch May 17, 2021 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port CSV operator from stanza #123

Port CSV operator from stanza #123

Mrod1598 commented Apr 27, 2021 •

edited by jsirianni

Loading

djaglowski left a comment

djaglowski left a comment

djaglowski left a comment

Port CSV operator from stanza #123

Port CSV operator from stanza #123

Conversation

Mrod1598 commented Apr 27, 2021 • edited by jsirianni Loading

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski left a comment

Choose a reason for hiding this comment

Mrod1598 commented Apr 27, 2021 •

edited by jsirianni

Loading