Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update Python Dependencies and remove unsued scripts in the repo #717

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented May 25, 2023

Fixes #643

Thi PR removes the integration test scripts in the repo, which are not used and have no purpose to sit in this repo, helps for the better maintainance of the project and Updates the Python dependencies.

@vasireddy99 vasireddy99 changed the title Remove Unsued scripts in the repo [chore] Update Python Dependencies and remove unsued scripts in the repo May 25, 2023
Copy link

@shuwpan shuwpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the two into separate PRs, otherwise it makes it harder to review

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented May 25, 2023

Please split the two into separate PRs, otherwise it makes it harder to review

I Was initially doing in two PRs but, the PR build was failing, if not updating the version of python. So had to keep it in one PR.

@vasireddy99 vasireddy99 requested a review from codeboten May 25, 2023 18:29
@codeboten
Copy link
Contributor

Looks like there's an error in the build:

Error: CustomMakeBuilder:MakeBuild - Make Failed: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

@vasireddy99
Copy link
Contributor Author

Looks like there's an error in the build:

Error: CustomMakeBuilder:MakeBuild - Make Failed: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

yeah looks like the failure is something related to this change looking into it now.

@vasireddy99
Copy link
Contributor Author

Looks like there's an error in the build:

Error: CustomMakeBuilder:MakeBuild - Make Failed: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

oh yes, Rebasing to the main has worked as it seems git merge has both changes in place led to conflict.

The PR is now ready to merge :-).

@codeboten
Copy link
Contributor

Thanks @vasireddy99

@codeboten codeboten merged commit e5bc4f6 into open-telemetry:main Jun 2, 2023
dblooman pushed a commit to teamkeel/opentelemetry-lambda that referenced this pull request Jun 2, 2023
…epo (open-telemetry#717)

Fixes open-telemetry#643

Thi PR removes the integration test scripts in the repo, which are not used and have no purpose to sit in this repo, helps for the better maintainance of the project and Updates the Python dependencies.
@vasireddy99 vasireddy99 deleted the removetf branch June 9, 2023 15:38
tomfrew pushed a commit to teamkeel/opentelemetry-lambda that referenced this pull request Mar 1, 2024
…epo (open-telemetry#717)

Fixes open-telemetry#643

Thi PR removes the integration test scripts in the repo, which are not used and have no purpose to sit in this repo, helps for the better maintainance of the project and Updates the Python dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Terraform Integration test script
3 participants